Repository navigation
Conversation
AdriTara
marked this pull request as draft
April 13, 2026 11:57
AdriTara
marked this pull request as ready for review
April 13, 2026 11:58
Member
|
Thanks for the work. Instead of rerouting np warnings through stdlib I'd rather have the specific warnings ignored only in the relevant call context (cfr. #1478). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
An error was raising while using
computeMatrixOperations filterValueson NumPy version 1.26.4. I think NumPy deleted the link to the warnings stdlib as of version 1.21.5 (See stackoverflow thread). Therefore, the script computeMatrixOperations.py fails on line 432, raising:Therefore, based on the same stackoverflow thread I modified all the files importing numpy to add support for warnings. The other option is to comment the line 432 as suggested in #1358 .